pypa / pypa/setuptools

setuptools.setup function does not warn on wrong user keywords

Open
#2,188 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
1.4k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

The setup function does not warn or fail when called with wrong user parameters

repro: take ANY valid setup.py file, change the 'name' parameter to 'names' and do a pip install .

this will cause pip to install UNKNOWN.version

Suggested fix:
have a checker on setup. Before calling _install_setup_requires, which checks the parameters, with good warning messages.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the setup function and the point before _install_setup_requires, then reproduce the issue by changing name to names in a valid setup.py and running pip install .. Determine how setup parameters are checked and what warning behavior is appropriate. Done means an invalid user keyword produces a clear warning or failure instead of installing UNKNOWN.version.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.