pypa / pypa/setuptools

Windows bytes API is deprecated

Open
#2,016 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
1.4k
Avg merge
1d 1h
Merged PRs (30d)
1

Description

With the recent introduction of builds on newer versions of visual studio (#1904), there are new deprecation warnings in the Appveyor tests like this:

self = <setuptools.sandbox.DirectorySandbox object at 0x00000224C2581F60>
path = b'MANIFEST.in', args = (), kw = {}
    def wrap(self, path, *args, **kw):
        if self._active:
            path = self._remap_input(name, path, *args, **kw)
>       return original(path, *args, **kw)
E       DeprecationWarning: The Windows bytes API has been deprecated, use Unicode filenames instead

These should be fixed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the warning in the AppVeyor tests and tracing the setuptools.sandbox.DirectorySandbox.wrap call shown in the issue. Search the sandbox implementation for the path remapping and Windows filesystem calls involved with b'MANIFEST.in'. Done means the deprecation warning is gone from the Windows test run while existing sandbox behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.