run build_clib before build_ext in develop command?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 1.4k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
The brotlipy project has a CFFI extension module that links to a static C library compiled using build_clib command.
When using the setuptools develop command (or pip install -e), the linkage with libbrotli fails because develop only calls build_ext without ensuring that build_clib has been called.
See https://github.com/pypa/pip/issues/4523
One workaround is to make a build_ext subclass that always runs build_clib before running itself:
https://github.com/python-hyper/brotlipy/pull/92
I wonder if this behavior should be the default?
thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the setuptools develop command and its build_ext/build_clib entry points, then compare the workaround described in brotlipy PR #92 and the linked pip issue. Done means editable installation reliably runs build_clib before build_ext so the CFFI extension can link against libbrotli.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, python
- Domain
- build-system, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100