pypa / pypa/packaging

Consider dropping GHA runs against pushes

Open
#397 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

infrastructure
Dominant language
Python
Stars
751
Forks
324
Avg merge
12h 58m
Merged PRs (30d)
3

Description

Since we require PRs to be synced to 'main', does running on push actually give us any benefit? As long as we don't cheat with admin privileges, I would think a successful run for a PR will be exactly the same as one on push. If that logic holds, then we are basically wasting free credits and energy running on push.

If people agree we can add logic such that runs against pushes only occur against other repos (i.e. people's personal forks); basically we add an if guard on the jobs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the GitHub Actions workflow triggers for pushes and pull requests, then confirm how the required sync-to-main rule affects equivalent runs. Add the proposed guard so push runs are limited to other repositories such as personal forks, and verify that pull-request checks and fork push runs still execute as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, python
Domain
ci-cd
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.