pypa / pypa/installer

Expose some helper functions in WheelSource

Open
#116 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component: sources type: feature
Dominant language
Python
Stars
148
Forks
68
Avg merge
7d 4h
Merged PRs (30d)
1

Description

When I extend installer to support custom installation logic, I found the following methods or attributes very useful and worth exposing as a public method:

  1. root_scheme. Currently retrieved by an unexported function _process_WHEEL_file, would be good to make it a property of WheelSource
  2. _determine_scheme(path, source, root_scheme). Currently, it is an unexported function, would be good to make it a method of WheelSource: WheelSource.determine_scheme(path). This, IMO, can achieve high cohesion.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how WheelSource, _process_WHEEL_file, and _determine_scheme(path, source, root_scheme) are used in the installer package. Review the existing public API and related tests before deciding how to expose root_scheme and determine_scheme; done means the helpers are available through WheelSource without breaking current installation behavior and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.