Replace boolean parameter with two methods.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 59
- Forks
- 94
- PR merge metrics
- No merged PRs in 30d
Description
This complicated signature, caused by a boolean parameter, should probably be re-written as two methods, get_command_obj and get_cached_command_obj, where the latter just returns self.command_obj.get(command). Of course, that's not a concern for this PR.
Originally posted by @jaraco in https://github.com/pypa/distutils/pull/307#discussion_r1898011172
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the method with the boolean parameter and its callers in the distutils source; the issue does not name a file or test. Compare the existing behavior with the proposed get_command_obj and get_cached_command_obj methods, then check relevant tests and callers. Done means the boolean-based interface is replaced consistently without changing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100