pyodide / pyodide/pytest-pyodide

More consistent object paths between host and target when unpickling

Open
#53 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
38
Forks
20
Avg merge
1d 23h
Merged PRs (30d)
1

Description

In https://github.com/pyodide/pyodide/pull/3202#issuecomment-1289408147 @hoodmane raised a good question,

How about changing pytest_pyodide to monkey patch JsException? I think this
change looks weird. If we're going to have a class with the same name both
inside and outside selenium, it should have the same path.

following https://github.com/pyodide/pytest-pyodide/pull/44 by @koenvo

Maybe more generally we could just install pyodide-py on the host, that way all those paths would already exist and we don't need to redefine or monkeypatch anything? I just uploaded it to PyPI, still need to automate the release.

This would be more general and should allow unpickling of other objects defined in this package if necessary.

The difficulty there is to make sure we install the pyodide-py version that matches the version of Pyodide used.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked pytest-pyodide pull request 44 and the referenced Pyodide discussion about monkey-patching JsException. Investigate how the pyodide-py package is installed and released, then determine how the host version should match the Pyodide version; done means host and target object paths support unpickling without ad hoc redefinitions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.