pyodide / pyodide/pyodide-build
Use `build.ProjectBuilder.check_dependencies` for the isolated build
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 18
- Forks
- 31
- Avg merge
- 8h 33m
- Merged PRs (30d)
- 1
Description
check_dependencies looks like a union of
- get_requires_for_build (== dependencies for the build backend such as setuptools, meson)
- build_system_requires (== dependencies in the pyproject.toml)
In the isolated build, we've been dealing with them separately. I guess we can use check_dependencies there too (no action required for this PR).
Originally posted by @ryanking13 in https://github.com/pyodide/pyodide-build/pull/152#discussion_r2020078344
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/build/_builder.py around check_dependencies and pyodide_build/pypabuild.py around lines 160-167. Compare the existing isolated-build dependency handling with the referenced method, then verify that the isolated build uses the unified check without changing dependency behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100