pymor / pymor/pymor

Add yaml-based Model loader?

Open
#853 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
Python
Stars
346
Forks
122
Avg merge
1d 11h
Merged PRs (30d)
32

Description

I would like to retire discretizers.disk and replace it by a generic config file format. Something like

type: StationaryModel
operator:
    type: LincombOperator
    operators:
        - L1.mat
        - L2.mat
    coefficients:
        - diffusion[0]
        - diffusion[1]
rhs: F1.mat
output_functional: C.mat
products:
    l2: l2.mat
    h1: h1.mat
parameters:
    diffusion:
        shape: 2
        range: [0.1, 10]

I haven't thought about the details yet, but the general idea would be to have a generic file format, which can be used to load arbitrary Models from disk. Any comments, @pymor/pymor-devs? I think one might also argue that the same could be achieved with few lines of Python code and that we actually do not need such functionality.

If nobody disagrees, I would start by moving discretizers.disk to the graveyard.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing discretizers.disk module and the proposed YAML example in this issue. Clarify the generic model-loading format and whether it should replace the module or be declined in favor of Python code. Done means the design decision and scope are agreed before implementation begins.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.