pymor / pymor/pymor

GenericIRKAReductor is difficult to subclass

Open
#2,104 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
Python
Stars
346
Forks
122
Avg merge
1d 11h
Merged PRs (30d)
32

Description

There is still a lot of repetition, but a lot of differences, in the subclasses of GenericIRKAReductor.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate GenericIRKAReductor and its subclasses, then compare the repeated code with the subclass-specific differences described in the issue. The issue names no files or tests; completion would require an agreed design that makes GenericIRKAReductor easier to subclass while reducing the repetition.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.