pymc-devs / pymc-devs/pytensor
Add rewrite for IncSubtensor(ignore_duplicates=True) when advanced indices are constant and contain no duplicates
Open
Nobody has claimed this yet.
graph rewriting
performance
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
This allows using the more efficient x[indices] += y, instead of np.add.at(x, indices, y)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the IncSubtensor rewrite implementation and its existing tests. Check how advanced indices, the ignore_duplicates=True condition, and constant indices are represented, then add coverage showing that duplicate-free indices use the more efficient x[indices] += y behavior instead of np.add.at(x, indices, y).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100