pymc-devs / pymc-devs/pytensor
Mention and test inputs can be > 1D in hessian_vector_prod
Open
Nobody has claimed this yet.
beginner friendly
docs
tests
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
I don't think there is any reason to require wrt and p to be 1d. As long as wrt and p have the same shape(s) everything should be fine.
Maybe we can add a test for that and remove the "1-dimensional" from the docs?
Originally posted by @aseyboldt in https://github.com/pymc-devs/pytensor/pull/858#pullrequestreview-2162812716
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the hessian_vector_prod implementation and its documentation, then find the existing tests for this entry point. Add coverage for matching wrt and p inputs with more than one dimension, and update the documentation to remove the 1-dimensional requirement.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, documentation, testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100