pymc-devs / pymc-devs/pytensor

Allow specifying shape of dtyped tensor constructors

Open
#835 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

beginner friendly
Dominant language
Python
Stars
644
Forks
208
Avg merge
2d 14h
Merged PRs (30d)
16

Description

dvector hardcodes shape=(None,). Would be nicer to make it a partial of vector with the fixed dtype to still allow providing a specific static shape if the user wants to

https://github.com/pymc-devs/pytensor/blob/193580990e9f7e7eebca98af217b960929656d29/pytensor/tensor/type.py#L847-L854

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in pytensor/tensor/type.py at lines 847-854 and compare dvector with vector. Confirm that dtyped constructors can accept an explicit static shape while retaining their fixed dtype; done means callers can provide a shape that is not limited to (None,).

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.