pymc-devs / pymc-devs/pytensor
Move constants inside OpFromGraph and remove unused inputs/outputs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
If we only have on instance of the same OpFromGraph Op we should move constant inputs inside, to allow a simpler internal graph at compilation time.
We shoud also remove any unused inputs/outputs. This was already noted as a todo in the the docstrings: https://github.com/pymc-devs/pytensor/blob/30b760f26366eda7ea26edb1993e521b9d6d55c8/pytensor/compile/builders.py#L173
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read pytensor/compile/builders.py around the referenced docstring and the OpFromGraph implementation. Trace how constants and unused inputs or outputs are represented, then add tests showing the intended simplification for a single OpFromGraph instance and confirming that the resulting graph remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100