pymc-devs / pymc-devs/pytensor

minor bug: jax tests reference jax.interpreters.xla.DeviceArray

Open
#660 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

beginner friendly bug jax tests
Dominant language
Python
Stars
644
Forks
208
Avg merge
2d 14h
Merged PRs (30d)
16

Description

Describe the issue:

https://github.com/pymc-devs/pytensor/pull/133 In this PR, the second branch of this conditional:

https://github.com/pymc-devs/pytensor/blob/d175203b4e00f48db9c61b68a5f70263a1fbb645/tests/link/jax/test_basic.py#L73-L77

was evidently not updated only because it is never executed in the tests.

cc @ricardoV94

Reproducable code example:
n/a
Error message:

No response

PyTensor version information:

n/a

Context for the issue:

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/link/jax/test_basic.py around lines 73–77 and review the linked PyTensor pull request for the intended conditional update. Run the relevant JAX tests, including coverage of the second branch. Done means the tests no longer reference jax.interpreters.xla.DeviceArray and the affected tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.