pymc-devs / pymc-devs/pytensor
Move `register_canonicalize` and similar helpers to rewriting module
Open
Nobody has claimed this yet.
beginner friendly
refactor
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
register_canonicalize is defined in tensor.rewriting.basic which doesn't make sense.
It should be defined in graph.rewriting.utils?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing tensor.rewriting.basic with graph.rewriting.utils and locating register_canonicalize and the other helpers intended to move. Trace their imports and existing tests before changing anything; done means the helpers are in the appropriate rewriting module and existing references continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100