pymc-devs / pymc-devs/pytensor
Efficient Conv Ops were removed accidentally
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
We removed the deprecated nnet module in https://github.com/pymc-devs/pytensor/pull/111
But we wanted to keep the Convolution Ops. Unfortunately we keept only the "abstract" ones, and not the fast variations implemented in conv.py. We should bring them back, including the rewrites that replace abstract forms by the equivalent fast ones.
https://discourse.pymc.io/t/very-slow-2d-convolution-with-pytensor/12118/6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the removal of the nnet module in PR #111 and the remaining convolution code in conv.py. Restore the fast convolution variations and the rewrites that replace abstract forms with equivalent fast ones, then verify that the efficient convolution operations are available again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100