pymc-devs / pymc-devs/pytensor
Make Sort/ArgSort axis a static Op property
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
SortOp and ArgSortOp take axis as a symbolic scalar input. Every backend and rewrite has to check whether it is constant, and when it is not there is nothing useful to do. #2144 moved axis to the constructor for Join and Split, and the same change here removes that check. pt.sort and pt.argsort keep their signatures.
op = SortOp(kind)(x, axis) # now
op = SortOp(kind, axis)(x) # proposed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the SortOp and ArgSortOp definitions and compare the constructor change described for Join and Split. Trace backend and rewrite uses that currently check whether axis is constant, while keeping pt.sort and pt.argsort signatures unchanged. Done means axis is constructor state, those checks are removed, and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100