pymc-devs / pymc-devs/pytensor
Don't allow AdvancedSubtensor and AdvancedIncSubtensor non-consecutive advanced indices
Open
Nobody has claimed this yet.
indexing
Op implementation
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
Make the constructors shuffle it so we never have to worry about this case in the rewrites (happen all the time, and we almost always bail out not to worry about complexity). Make the AdvancedOp refuse already at init looking at idx_list
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the AdvancedSubtensor and AdvancedIncSubtensor constructors and inspect how init processes idx_list. Trace the rewrites that currently bail out for non-consecutive advanced indices. Done means constructors normalize or reject that case consistently, so the affected rewrites no longer need to handle it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100