pymc-devs / pymc-devs/pytensor
Reorganize `pytensor/link/numba/dispatch/sparse/math.py`
Open
Nobody has claimed this yet.
maintenance
numba
sparse variables
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
After some discussion initiated after #1860 (see this exchange and this), we agreed it would be good to reorganize pytensor/link/numba/dispatch/sparse/math.py in such a way that overloads only route to the correct njitted function (implemented in a separate module), instead of implementing all of them inline.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pytensor/link/numba/dispatch/sparse/math.py and the discussions linked from #1860 and #1856. Identify the inline overload implementations and the agreed module boundary; done means overloads route to separate njitted functions without changing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100