pymc-devs / pymc-devs/pytensor
Rewrite solve and dot with diagonal matrices
Open
Nobody has claimed this yet.
graph rewriting
linalg
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
We have special rewrites for Det and MatrixInverse, but not for Solve/Dot. Simplifying these cases should allow bridging the gap between things like batched univariate normal and multivariate normal with diagonal covariance
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing rewrites for Det and MatrixInverse and compare how they handle diagonal matrices. Define and test the corresponding Solve and Dot simplifications, with completion demonstrated by bridging batched univariate normal and multivariate normal cases with diagonal covariance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100