pymc-devs / pymc-devs/pytensor
Compute `is_matrix_transpose` when initializing `Dimshuffle`
Open
Nobody has claimed this yet.
beginner friendly
graph rewriting
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
I tried it in this commit: https://github.com/pymc-devs/pytensor/pull/1592/commits/07e50e20e4ae952a7aba7b68cf1a97373fa3eba5, some tests failed which need to be checked. Nothing crazy should be needed, maybe I did a small error in the commit
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Dimshuffle implementation and the attempted change in commit 07e50e20e4ae952a7aba7b68cf1a97373fa3eba5. Run the tests affected by that commit and inspect the failures. Done means is_matrix_transpose is computed during Dimshuffle initialization and the relevant test suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100