pymc-devs / pymc-devs/pytensor
Rewrite useless cumsum/cumprod on dim_length==1
Open
Nobody has claimed this yet.
beginner friendly
graph rewriting
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
When doing cumsum/cumprod on an axis that has static shape of 1, we have a no-op. We should rewrite it away
This can ve registered as a canonicalization rewrite.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the canonicalization rewrite entry points for cumsum and cumprod and the handling of statically known axis lengths. Confirm how no-op rewrites are tested. Done means cumsum and cumprod on an axis with dim_length==1 are removed while equivalent expressions retain their results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100