pymc-devs / pymc-devs/pytensor

Some sparse tests failing on scipy 1.16

Open
#1,506 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug SciPy compatibility sparse variables
Dominant language
Python
Stars
644
Forks
208
Avg merge
2d 14h
Merged PRs (30d)
16

Description

Description

Marked as skip here https://github.com/pymc-devs/pytensor/commit/2ab60b39e4622b1d9d677ab3e598d752bd25b17e

I didn't have time to check the reason behind it. It seems scipy is more strict about indptr lengths, and in the gradient we get some cases where the indptr is longer than the rows it has. Perhaps something we can tweak in the perform level

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the sparse tests skipped in commit 2ab60b39e4622b1d9d677ab3e598d752bd25b17e and reproduce the failures with SciPy 1.16. Inspect the gradient cases involving indptr lengths and the relevant perform-level behavior. Done means the sparse tests pass without the skip while preserving valid indptr and row relationships.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.