pymc-devs / pymc-devs/pytensor
Do we need pickler from pytensor?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
I discovered this file but literally do not know we had to deal with it for all the 5 years of my involvement in pymc
https://github.com/pymc-devs/pytensor/blob/5affc30827add3ebe3495d150edf62b782def1db/pytensor/misc/pkl_utils.py
I found it is used in https://github.com/pymc-devs/pytensor/blob/5affc30827add3ebe3495d150edf62b782def1db/pytensor/compile/function/__init__.py#L78
Can we just implement a proper __getstate__?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pytensor/misc/pkl_utils.py and the referenced use in pytensor/compile/function/init.py. Compare the existing pickler's role with the proposed getstate approach, then establish whether the custom utility can be removed or must remain and record that decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100