pymc-devs / pymc-devs/pytensor
Support new `jax.random.key` classes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
Currently, pytensor is converting the random Generator objects using jax_typify. The random_state is treated as a simple array of uint32s, which is fine for the old jax.random.PRNGKey class. The new typed key class handles things a bit differently, and jax plans to eventually deprecate the old PRNGKey approach. I'm 100% sure that the current approach will be affected by that deprecation or not, but it might be worth to try and adapt the typify code to use the new keys.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pytensor/link/jax/dispatch/random.py, especially the jax_typify handling described in the issue, and compare it with JAX's typed key behavior in the linked documentation. Determine how the new key class should be supported without breaking the existing PRNGKey path; done means random handling works with the new typed keys.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100