pymc-devs / pymc-devs/pytensor
Remove C code from conv tests
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
after #124 is closed, there are still changes needed to avoid using C code as reference and instead implement tests against scipy implementations as done in e.g. pytorch
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the convolution tests in this repository, then read the referenced sections of PyTorch's test/nn/test_convolution.py for the proposed scipy-based approach. Replace the remaining C-code reference tests after #124 with tests against scipy implementations, and confirm the convolution test suite passes without relying on C code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100