pymc-devs / pymc-devs/pytensor
Consider specialized DimShuffle C-implementation
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
Right now DimShuffle uses an external C-op that is generic over variations of DimShuffle. In the older time it used to be one of the regular unreadable inplice c_code methods, which used the input/output ndim information directly, and could just define shape/strides as a constant size array and allocate it without a loop, like we have now.
This is probably a minor optimization, may not even buy us anything. This issue is a low-priority thing to just keep in mind.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating DimShuffle's external generic C-op and compare it with the older inline c_code implementation described in the issue. Benchmark the current and specialized approaches, including constant-size shape and stride arrays; done means either a measured optimization or evidence that no change is worthwhile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, python
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100