pymc-devs / pymc-devs/pytensor

Stop running numba tests in object mode for coverage

Open
#1,220 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs info numba tests
Dominant language
Python
Stars
644
Forks
208
Avg merge
2d 14h
Merged PRs (30d)
16

Description

Description

With numba 0.61 coverage will work for lines that are seen during compilation: https://numba.readthedocs.io/en/stable/release/0.61.0-notes.html#added-compile-time-code-coverage

This means we may be able to stop running tests in object mode just for coverage purposes: https://github.com/pymc-devs/pytensor/blob/cc8c499272e9b3e7e3637e8b6eaca7fb35b20376/tests/link/numba/test_basic.py#L274-L279

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect tests/link/numba/test_basic.py around lines 274-279, then read the linked Numba 0.61 coverage notes. Check how the tests currently use object mode for coverage and remove that special handling if the updated coverage behavior supports it. Run the relevant Numba test file and confirm coverage still includes the expected lines.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.