pymc-devs / pymc-devs/pytensor
Make Elemwise a subclass of Blockwise
Open
Nobody has claimed this yet.
Op implementation
refactor
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
All general Blockwise methods (infer_shape, grad, ...) work for Elemwise which is just a trivial Blockwise function with signature "(),()...()->(),...,()` (that is one entry for each input and output).
We should make Elemwise a subclass of Blockwise and remove any redundant methods.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the Elemwise and Blockwise class definitions and comparing their general methods, including infer_shape and grad; done means Elemwise subclasses Blockwise and redundant methods are removed without changing the stated signature or behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100