pymc-devs / pymc-devs/pytensor
Remove redundant code after numpy < 2.0 is deprecated
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
I've noticed that some of the code like this is redundant now. E.g.
x * np.array(math.log(2.0)).astype(x.dtype)is now the same asx * math.log(2.0)because numpy now uses the type ofxhere. For backwards compatibility, maybe we should leave theastypeconversion for now, but once numpy 1.26 support is dropped, this won't be needed.
Originally posted by @brendan-m-murphy in https://github.com/pymc-devs/pytensor/pull/1194#discussion_r1954233758
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named in the issue. First locate occurrences of the described astype pattern and check the project's NumPy support policy; done means redundant conversions are removed only after NumPy 1.26 support is dropped, with the relevant test suite passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100