pymc-devs / pymc-devs/pytensor
Consider reverting canonicalization rewrites in `fast_compile` mode.
Open
Nobody has claimed this yet.
graph rewriting
- Dominant language
- Python
- Stars
- 644
- Forks
- 208
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 16
Description
Description
Not sure this commit was warranted: https://github.com/aesara-devs/aesara/commit/8cbd9840d315a48dafb7f67e5d6cc470a0c84044
If no basic functionality depends on it, I would suggest we don't run canonicalizations in a fast_compile mode.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading commit 8cbd9840d315a48dafb7f67e5d6cc470a0c84044 and tracing how canonicalization rewrites are applied in fast_compile mode. Determine whether basic functionality depends on those rewrites; done means reaching a supported decision about retaining or reverting them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100