Consolidate typing for `coords`
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- numpy, python
- Domain
- developer-experience
Research direction
Start by comparing the coords annotations and conversions in pymc/model/core.py and pymc/backends/arviz.py with the existing dims and shape typing in pymc/distributions/shape_utils.py. Consolidate the coords type across the cited locations and expose a consistent annotation that improves downstream typing without relying on dict[str, Any].
Written by the indexing model from the issue text.
Description
coords have a mix of types in the codebase. Some places:
The conversion type:
Seems to be a mix of Sequence and Sequence | np.ndarray so some
consolidation would be nice. For example, there is already a various amount of
typing for other objects like dims and shape:
My main concern is not within pymc package directly but in the downstream
usage where using dict[str, Any] is probably the most common way to type
coords. So exposing would have some typing benefit.
- Dominant language
- Python
- Stars
- 9.8k
- Forks
- 2.3k
- Avg merge
- 21h 39m
- Merged PRs (30d)
- 5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pymc-devs/pymc
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
docs
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
test md OpenCI
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
bug client
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100