pymc-devs / pymc-devs/pymc-extras
Update find_MAP's return type annotation to DataTree
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 143
- Forks
- 91
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 19
Description
Update the return type annotation on find_MAP here from dict[str, np.ndarray] | tuple[...] to DataTree. The function has a single return idata and the docstring already says map_result: DataTree.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open pymc_extras/inference/laplace_approx/find_map.py around lines 176-181 and inspect find_MAP's return annotation, its single return idata, and the existing docstring. Update the annotation to DataTree, then verify it matches the documented map_result type and the function's returned value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 90/100