pymc-devs / pymc-devs/pymc-examples

BUG: B matrix orientation in SEM workflow notebook is incorrect.

Open
#824 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
398
Forks
325
Avg merge
9d 15m
Merged PRs (30d)
1

Description

SEM Workflow:
https://www.pymc.io/projects/examples/en/latest/case_studies/bayesian_sem_workflow.html:

Issue description

There is a minor issue in the interpretation of the B matrix specification. The orientation of the target -> predictors encoding is incorrect. The correct structure is inverted. The row indexes denote the target the column indexes the predictors

Proposed solution

Will add a fix to correct the orientation. The interpretation i this case doesn't change, it's how the mistake snuck through.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the linked SEM Workflow notebook and locate the explanation of the B matrix specification. Compare its target-to-predictor orientation with the stated convention, then update the interpretation so rows denote targets and columns denote predictors; the notebook should present the corrected orientation without changing the model's interpretation.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook, python
Domain
data, documentation
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.