pymc-devs / pymc-devs/nutpie

compile_pymc creates an 'obs_id' coord

Open
#79 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
207
Forks
28
Avg merge
7d 21h
Merged PRs (30d)
1

Description

I couldn't totally find where this happens but compile_pymc creates an "obs_id" coordinate automatically. If the user doesn't provide that coordinate it gets populated as None. This causes this line of code to throw an error

coords = {name: pd.Index(vals) for name, vals in model.coords.items()}

as pd.Index(vals) is expecting vals to be an array of some kind.

Should we auto-populate the obs_id coordinate as an array of the length of the number of observations?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing compile_pymc to find where the obs_id coordinate is created, then inspect the pd.Index conversion shown in the report. Determine the expected behavior when the user omits obs_id and verify that model.coords can be converted without passing None values.

Written by the indexing model from the issue text.

Assessment

Tech stack
pandas, python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.