Type mismatch in raw logp return
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 207
- Forks
- 28
- Avg merge
- 7d 21h
- Merged PRs (30d)
- 1
Description
These two should agree, but on every system I am aware of c_int is 32 bits. I believe that was also probably the intent, so the easiest fix is change the second to numba.types.int32
https://github.com/pymc-devs/nutpie/blob/daf1ac32ef18c4da9ddc09c9d5571fc7461b496c/src/pymc.rs#L29
https://github.com/pymc-devs/nutpie/blob/daf1ac32ef18c4da9ddc09c9d5571fc7461b496c/python/nutpie/compile_pymc.py#L1014
Noticed while working on #336
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the return type at src/pymc.rs#L29 with the generated raw logp type at python/nutpie/compile_pymc.py#L1014. Align the two declarations with the intended 32-bit type, then verify that the raw logp return types agree and run the relevant project checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100