pylint-dev / pylint-dev/astroid

[2.0 bugs] unittest_manager ast_from_class tests

Open
#253 5 comments 0 reactions 0 assignees View on GitHub
2.0 Bug 🪳
Dominant language
Python
Stars
582
Forks
357
Avg merge
1d 1h
Merged PRs (30d)
23

Description

Originally reported by: **BitBucket: [ceridwenv](http://bitbucket.org/ceridwenv), GitHub: @ceridwen**

---

This method is now redundant, given the ast_from_class function in raw_building. Should I move these tests to unittest_raw_building? If so, the API is different: Manager.ast_from_class always returns a ClassDef node that is the child of whatever module it's in, while raw_building.ast_from_class returns only the class itself. Should I just write new tests?

---
- Bitbucket: https://bitbucket.org/logilab/astroid/issue/253

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the tests in unittest_manager and compare their Manager.ast_from_class expectations with raw_building.ast_from_class. Check unittest_raw_building and run the relevant test files before deciding whether to move or rewrite the cases. Done means the redundant coverage is removed or relocated, the API differences are covered, and the test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.