pyfar / pyfar/sofar

Add check for dimension of string variables to verify

Open
#130 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
34
Forks
4
Avg merge
11m
Merged PRs (30d)
2

Description

Section 4.5 of AES69 states that 'The string dimension S shall be the last dimension of a multi-dimensional character array', which is currently not checked. A corresponding check should be added to verify the definition of conventions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the existing checks that verify SOFA variable dimensions and conventions, then inspect how character arrays and the string dimension S are represented. Done means multi-dimensional character arrays are rejected when S is not their last dimension, with the corresponding verification covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.