datatree: Implement in-place binary ops
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
I suspect this actually needs a different implementation, in order to handle error recovery properly.
I would suggest handling this like
Dataset._inplace_binary_op, which builds resultDatasetand then replaces the contents of the current dataset with those of the new dataset.
Originally posted by @shoyer in https://github.com/pydata/xarray/pull/9619#discussion_r1800471609
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the datatree binary-operation implementation and Dataset._inplace_binary_op, which the issue identifies as the suggested model. Compare how the dataset replacement approach handles error recovery, then determine the corresponding datatree behavior and verify it with the relevant existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100