map_blocks fails with lazy loaded dask array
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
What is your issue?
Copied from https://github.com/xarray-contrib/datatree/issues/152
Issue
Hi,
I'm very excited about this package and I'm just familiarising myself to see where I can use it for my use cases. I followed the example in the documentation to apply a groupby to the datatree. However, I did use dask because my dataset is too large to fit it into memory. I realised that my group_by function is not being applied to lazy loaded dask arrays.
Minimal example
import datatree
import xarray as xr
import pandas as pd
import dask
import numpy as np
def group_by(da, groupby_type="time.floor('1D')"):
gb = da.groupby(groupby_type)
mean = gb.mean()
return mean
times = pd.date_range("2022-09-01","2022-09-03", freq="6H")
a=xr.Dataset({'x': ('time', np.random.randint(0,10,len(times)))}, coords={'time':times})
b=xr.Dataset({'x': ('time', dask.array.random.randint(0,10,len(times)))}, coords={'time':times})
dt=datatree.DataTree.from_dict({'first':a, 'second':b})
dt.map_blocks(group_by, kwargs={"groupby_type": "time.day"}, template=dt)
Please compare the results for the eager (a) and lazy (b) loaded datasets below:
DataTree('None', parent=None)
├── DataTree('first')
│ Dimensions: (day: 3)
│ Coordinates:
│ * day (day) int64 1 2 3
│ Data variables:
│ x (day) float64 5.75 7.75 6.0
└── DataTree('second')
Dimensions: (time: 9)
Coordinates:
* time (time) datetime64[ns] 2022-09-01 2022-09-01T06:00:00 ... 2022-09-03
Data variables:
x (time) int64 dask.array<chunksize=(9,), meta=np.ndarray>
Any ideas what is going wrong?
This can likely be generalised for any map_blocks function:
def func(da):
return da.mean('time')
b=xr.Dataset({'x': ('time', dask.array.random.randint(0,10,len(times)))})
dt=datatree.DataTree.from_dict({'second':b})
dt.map_blocks(func, template=dt)
DataTree('None', parent=None)
└── DataTree('second')
Dimensions: (time: 9)
Dimensions without coordinates: time
Data variables:
x (time) int64 dask.array<chunksize=(9,), meta=np.ndarray>
Versions
xarray: 2022.6.0
datatree: 0.0.9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the DataTree.map_blocks entry point and reproduce the minimal eager-versus-lazy examples from the issue. Compare the resulting trees and verify that the lazy dask dataset applies the groupby or mean operation and produces the same structural result as the eager dataset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, pandas, python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100