pydata / pydata/xarray

Forbid path-like child names

Open
#9,490 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug contrib-good-first-issue topic-DataTree
Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

It would also be nice to add a check like this for child names.

Originally posted by @shoyer in https://github.com/pydata/xarray/pull/9378#pullrequestreview-2301368526

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing check referenced in pull request #9378 and trace where child names are validated. Identify the relevant validation entry point and tests; done means path-like child names are rejected consistently with the existing check.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.