pydata / pydata/xarray

Deprecate vectors of size-2 in `cross`

Open
#9,232 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

What is your issue?

numpy 2 has deprecated passing 2D vectors to np.cross. We should do the same presumably, or fix it so that the numpy warning isn't raised..

I deleted the doctests in https://github.com/pydata/xarray/pull/9177 to fix CI.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating xarray's cross implementation and reviewing the doctests removed in pull request 9177. Clarify whether the goal is to mirror NumPy's deprecation or avoid its warning, then verify the chosen behavior with the relevant cross checks and CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.