pydata / pydata/xarray

Stricter check for .array attribute

Open
#9,016 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

@dcherian this is the place which I think shows that we should be more careful about how we look for the .array attribute on wrapped data.

Originally posted by @TomNicholas in https://github.com/pydata/xarray/pull/8872#discussion_r1594294056

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the discussion linked from pull request 8872 and examine how wrapped data is checked for the .array attribute. Trace the relevant lookup path in xarray and define the stricter behavior from that discussion; the work is done when wrapped data no longer produces an incorrect .array match and the behavior is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.