DataTree should support Hashable names.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
What is your issue?
In porting xarray-contrib/datatree into pydata/xarray. We discovered some type mismatches.
The general feeling was that we should support Hashable in order to improve DataTree interactions with Dataset and DataArrays.
The quick solution of changing the name type to Hashable in NamedNode fails quickly because of it's PathPurePath inheritance.
This issue just tracks that we want to come back to this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked discussion in PR #8789 and the existing DataTree, Dataset, DataArray, and NamedNode interfaces. Investigate how NamedNode's PathPurePath inheritance prevents changing the name type to Hashable. Done means DataTree names support Hashable values without breaking those interactions or existing name behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100