pydata / pydata/xarray

Support `inline_array` kwarg in `open_zarr`

Open
#8,095 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug topic-backends topic-zarr
Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

cc @TomNicholas

What happened?

There is no way to specify inline_array in open_zarr. Instead we have to use open_dataset.

Minimal Complete Verifiable Example
import xarray as xr

xr.Dataset({"a": xr.DataArray([1.0])}).to_zarr("temp.zarr")
xr.open_zarr('temp.zarr', inline_array=True)
ValueError: argument inline_array cannot be passed both as a keyword argument and within the from_array_kwargs dictionary
xr.open_zarr('temp.zarr', from_array_kwargs=dict(inline_array=True))
ValueError: argument inline_array cannot be passed both as a keyword argument and within the from_array_kwargs dictionary

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the open_zarr and open_dataset entry points and how the inline_array and from_array_kwargs arguments are forwarded. Reproduce the provided Dataset and open_zarr example, then verify that inline_array can be supplied without the reported ValueError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.