pydata / pydata/xarray

Add pop methods

Open
#7,851 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

Is your feature request related to a problem?

It's not related to a problem. I would find useful to have pop methods.

Describe the solution you'd like

Is it feasible to add pop methods?

For example, instead of doing this:

import xarray as xr

ds = xr.Dataset({"foo": None})
foo = ds["foo"]
ds = ds.drop_vars("foo")

I would like to be able to do this:

foo = ds.pop_vars("foo")
Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Dataset.drop_vars implementation and the related Dataset API tests. Trace how a variable is selected and removed, then determine the expected pop_vars return value and behavior from the example. Done means the requested pop method works while preserving existing drop_vars behavior and has coverage for the shown usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.