pydata / pydata/xarray

xarray.DataArray.str.cat() doesn't work on chunked data

Open
#6,828 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug topic-dask
Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

What happened?

I was trying to concatenate some DataArrays of strings, and it kept just returning the first DataArray without any changes.

What did you expect to happen?

I was expecting it to just provide the strings, concatenated together with the spearator between them.

Minimal Complete Verifiable Example
da = xr.DataArray(
    np.zeros((2, 2)).astype(str),
    coords={'x':np.arange(2), 'y': np.arange(2)},
    dims=['x', 'y'])

dac = da.chunk()

print((da == dac).values.all())
print((da.str.cat(da, sep='--') == dac.str.cat(dac, sep='--')).values.all())
print((da.str.cat(da, sep='--') == dac.compute().str.cat(dac.compute(), sep='--')).values.all())

>>> True
>>> False
>>> True
MVCE confirmation
  • Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • Complete example — the example is self-contained, including all data and the text of any traceback.
  • Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • New issue — a search of GitHub Issues suggests this is not a duplicate.
Relevant log output

No response

Anything else we need to know?

No response

Environment

INSTALLED VERSIONS

commit: None
python: 3.8.10 (default, Mar 15 2022, 12:22:08)
[GCC 9.4.0]
python-bits: 64
OS: Linux
OS-release: 5.11.0-27-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: C.UTF-8
LOCALE: ('en_US', 'UTF-8')
libhdf5: 1.12.2
libnetcdf: 4.9.0

xarray: 2022.3.0
pandas: 1.4.2
numpy: 1.22.4
scipy: 1.8.1
netCDF4: 1.6.0
pydap: None
h5netcdf: 1.0.1
h5py: 3.6.0
Nio: None
zarr: 2.11.3
cftime: 1.6.1
nc_time_axis: None
PseudoNetCDF: None
rasterio: 1.2.10
cfgrib: None
iris: None
bottleneck: None
dask: 2022.7.0
distributed: None
matplotlib: 3.5.2
cartopy: None
seaborn: None
numbagg: None
fsspec: 2022.5.0
cupy: None
pint: None
sparse: None
setuptools: 62.3.2
pip: 22.1.2
conda: None
pytest: None
IPython: 8.3.0
sphinx: None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the xarray.DataArray.str.cat() entry point and reproduce the minimal example with both eager and chunked DataArrays. Trace why the chunked result differs from the computed result, then verify that concatenation with sep='--' agrees for both cases and add or update regression coverage if the relevant test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.