Suggestion for merge/concat(combine_attrs='override')
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
What is your issue?
Hi,
The current behavior of merge/concat(combine_attrs='override') is to copy attrs from the first object to the result.
However, for me at least, the overrride word implies that the attrs of the second object is copied over the first one.
In any case, it would be nice to let the user decides which attrs is kept in case of 'override'. From https://docs.xarray.dev/en/stable/generated/xarray.concat.html, it does not seem available?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the merge and concat entry points and the combine_attrs option described in the linked xarray.concat documentation. Determine how the current override behavior is specified and identify the API decision needed for choosing which object's attrs are retained. Done should include documented behavior and tests covering the selected override semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100