Add coarsen, rolling and weighted to generate_reductions
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
Is your feature request related to a problem?
Coarsen reductions are currently added dynamically which is not very useful for typing.
This is a follow-up to @Illviljan in https://github.com/pydata/xarray/pull/6702#discussion_r900700532_
Same goes for Weighted.
And similar for Rolling (not sure if it is exactly the same though?)
Describe the solution you'd like
Extend the generate_reductions script to include DataArrayCoarsen and DatasetCoarsen.
Once finished: use type checking in all test_coarsen tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the generate_reductions script and inspect how DataArrayCoarsen and DatasetCoarsen are currently added. Then review the test_coarsen tests and run their type checks. Done means the coarsen classes are included by the generator and all test_coarsen tests pass type checking; clarify the remaining Weighted and Rolling scope if needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100